Skip to content

Use "int = 0" SFINAE in std::function to improve compiler throughput#244

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:function_on_off_sfinae
Dec 2, 2019
Merged

Use "int = 0" SFINAE in std::function to improve compiler throughput#244
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:function_on_off_sfinae

Conversation

@BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Nov 1, 2019 •
edited
Loading

Description

Use on/off SFINAE in std::function when not blocked by compiler bugs.

Xiang Fan of the C1XX frontend team reported that this improved throughput in a customer submitted benchmark.

Checklist

  • I understand README.md. I also understand that acceptance of
    community PRs will be delayed until the test and CI systems are online.
  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before CI is online, leave this unchecked for
    initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository and
    the C++ Working Draft as a reference (and any other cited standards).
    If they were derived from a project that's already listed in NOTICE.txt,
    that's fine, but please mention it. If they were derived from any other
    project (including Boost and libc++, which are not yet listed in
    NOTICE.txt), you must mention it here, so we can determine whether the
    license is compatible and what else needs to be done.

@BillyONeal BillyONeal requested a review from a team as a code owner November 1, 2019 00:15
StephanTLavavej
StephanTLavavej approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No merge conflicts with #226 although they work towards the same goal.

@BillyONeal
Copy link
Member Author

BillyONeal commented Nov 1, 2019

We mess up clang-format sometimes too :P

@BillyONeal
Copy link
Member Author

BillyONeal commented Nov 1, 2019

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 1, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member Author

BillyONeal commented Nov 1, 2019

Looks like this is ICEing the chk build of the compiler for now....

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Nov 1, 2019 •
edited
Loading

Looks like this is ICEing the chk build of the compiler for now....

Clearly you are mistaken; the first post states "all tests pass":

image

@sylveon
Copy link
Contributor

sylveon commented Nov 1, 2019

You're telling me checking this box will fix all my build issues? Sign me up

@StephanTLavavej StephanTLavavej added the blocked Something is preventing work on this label Nov 1, 2019
StephanTLavavej
StephanTLavavej requested changes Nov 1, 2019
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FE team needs to fix the ICE you encountered, and then that needs to ship in a Preview, before we can merge this.

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 2, 2019

Cross-reference: this is related to #187.

@StephanTLavavej StephanTLavavej changed the title Use on/off SFINAE in std::function, as requested by Xiang Fan of the C1XX frontend team Use "int = 0" SFINAE in std::function to improve compiler throughput Nov 2, 2019
@miscco
Copy link
Contributor

miscco commented Nov 2, 2019

Should that also contain the fixes from @CaseyCarter concerning unique_ptr and hash_map

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 2, 2019

That’s a good question. @BillyONeal, I suspect that #248 is the same bug, so @miscco ’s idea of grouping them together should save time. #249 appears to be a different bug.

@BillyONeal BillyONeal removed the blocked Something is preventing work on this label Nov 26, 2019
@BillyONeal
Use on/off SFINAE in std::function when not blocked by compiler bugs.
8e07b9b 
Xiang Fan of the C1XX frontend team reported that this improved throughput in a customer submitted benchmark.
@BillyONeal BillyONeal force-pushed the function_on_off_sfinae branch from 15c172a to 8e07b9b Compare November 26, 2019 05:34
@BillyONeal BillyONeal self-assigned this Dec 2, 2019
@BillyONeal BillyONeal merged commit a403449 into microsoft:master Dec 2, 2019
@BillyONeal BillyONeal deleted the function_on_off_sfinae branch December 2, 2019 22:37
@StephanTLavavej StephanTLavavej mentioned this pull request Dec 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BillyONeal BillyONeal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BillyONeal @CaseyCarter @sylveon @StephanTLavavej @miscco

Comments